fix(eth): properly return vm error in all gas estimation methods#13389
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes error handling across gas estimation methods to ensure consistent output of VM errors during reverts. The change addresses inconsistencies where some gas estimation paths returned full error details including VM errors while others only returned basic execution failure messages.
- Introduces a new centralized error creation function
NewErrExecutionRevertedFromResult - Moves Ethereum revert parsing logic to a more appropriate location in the
ethtypespackage - Updates all gas estimation methods to use the standardized error format
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| node/impl/gasutils/gasutils.go | Updated to use standardized error creation for consistent VM error reporting |
| node/impl/eth/gas.go | Replaced custom error handling with centralized error creation function |
| node/impl/eth/utils.go | Removed duplicate Ethereum revert parsing logic |
| chain/types/ethtypes/eth_types.go | Added exported ParseEthRevert function with proper documentation |
| api/api_errors.go | Added NewErrExecutionRevertedFromResult helper function for consistent error creation |
| CHANGELOG.md | Added entry documenting the fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
wjmelements
reviewed
Oct 15, 2025
wjmelements
approved these changes
Oct 15, 2025
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
aceppaluni
pushed a commit
to aceppaluni/lotus
that referenced
this pull request
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realised this is why we don't have consistent output on reverts, sometimes we get the
vm errorand sometimes not.Same failure case, slightly different pathways: